[elrepo-devel] a few comment about elrepo's packages

[Farkas Levente]

hi,
yesterday i look into the packages in elrepo and i have a few comments:
- it'd be nice to replace the .el5.elrepo tag in the specfiles with %{?dist}

- most of these modules has no upstream source in this case it'd be 
better to version it according to the kernel version like the realtek 
and intel network driver eg. in stead of coretemp-1.1 the 
coretemp-2.6.27.8 would be more talkative (ie. i prefer that way for all 
packages).

- why do you always use a specific kmodtool in stead of the in distro 
/usr/lib/rpm/redhat/kmodtool? most of the case your version contains 
only minor changes. anyway most of this script is use the "old":
modules=( \$(rpm -ql kmod-${kmod_name}${dashvariant} | grep '\.ko$') )
in stead of the
modules=( \$(find /lib/modules/${verrel}${variant}/extra/${kmod_name} \
           | grep '\.ko$') )
the reason why the second is better since the above not working if you 
would like to install kernel modules during the install ie. you have a 
kickstart file with kmod packages than the first fail since the rpm is 
not installed at that stage when the kmod's post section run. ok some 
kmod's like intel use the later form:-) but it'd be useful to somehow 
standardize the kmodtool and spec file templates!

- also some of the kmodtool use kabi-modules some the kernel-modules 
provides.

- some kmodtool (like fuse) create file /etc/depmod.d/${kmod_name}.conf 
but don't include it in the filelist while some (e1000) do not create it 
but include it in the filelist. imho both are wrong.

- and the most important why don't you follow the centos kmod scheme ie. 
using it's own find-requires.ksyms? currently centos' kmod can be used 
with any centos AND custom centos kernel since you don't remove any kabi 
tracking info eg coretemp's requires contains:
---------------------------------------------
kernel(rhel5_arch_i386_kernel_ga) = d1c30e0a553e9225eebd1b866e0d3ed7a6154147
kernel(rhel5_kernel_module_ga) = 1b051ce57d6b18fdf071786f6f7296d3d0ab28f9
kernel(rhel5_lib_ga) = 088a6b77cde4f82c65b0d7f34802cfa41d209328
kernel(rhel5_fs_sysfs_ga) = bb43e88ba2b9ebed086513342d9a5a18ed9355a7
kernel(rhel5_vmlinux_ga) = 2bf444396ff7060828059d7a5379435140aee48a
kernel(rhel5_drivers_base_ga) = 2490efa8790e7d4b3c7ae4536866c48f1334a356
kernel(rhel5_mm_ga) = 09f63dfab81bba7e01a2bf693f5ce125db466051
kernel(rhel5_kernel_ga) = 2cd142708e2d573b2de522df5df87aaeb7c1d298
kernel(rhel5_drivers_hwmon_ga) = 73ec105e064d9b09c6d44c6584f517b73a7d80ab
kernel(rhel5_drivers_xen_core_ga) = 5308a7766723999bbea99a33dde1bbb76fee41ca
---------------------------------------------
this is very bad since those who build any kind of custom kerel have to 
rebuild your src.rpm or rewrite the spec. it's almost the same as not 
using weak-updates.

the best would be some kind of packaging howto with comment and 
templates which can be used in all kmod packages.
regards

-- 
   Levente                               "Si vis pacem para bellum!"