[elrepo] New package proposel: kmod-ftsteutates

[Phil Perry]

On 11/12/2019 16:11, Jens Kuehnel wrote:
> Am 09.12.19 um 00:19 schrieb Phil Perry:
>> On 08/12/2019 21:23, Jens Kuehnel wrote:
>>> Hi elrepo-Users,
>>>
>>> I have created a new kmod package for ftsteutates for my new Hetzner 
>>> Server based on a Fujitsu D3417-B1.
>>>
>>> The RPM and SRPM can be found here:
>>>
>>> https://www.kuehnel.org/kmod-ftsteutates/
>>>
>>> It is based on the kmod-e100 package for EL8 and does not use the 
>>> source from the kernel upstream, but instead from the fujitsu FTP 
>>> site. The c file are in principle the same.
>>>
>>> I copy a template file from the documentation to /etc/sensors.d/. If 
>>> this is a problem this could be removed of course. But the output of 
>>> sensors is very unusable without this files and the files are very 
>>> different from one board to the next.
>>>
>>> Hopefully you can include it into elrepo.
>>>
>>> And thanks for all the work that you do!
>>>
>>> CU
>>> Jens
>>
>> Hi Jens,
>>
>> Thank you for the contribution. I'll take a look this week.
>>
>> I wonder why Red Hat did not enable this driver in their el8 kernel?
> That I can not tell you. I was wondering the same.
> 
> 
>> I see no issue with installing the template config file. My only 
>> suggestion is we add a Requires(post) for dmidecode.
> 
>> Requires(post): %{_sbindir}/dmidecode
> Done.
> 
>> We will also need to add something to %preun to remove 
>> /etc/sensors.d/fts-teutates-${BOARDVERSION}.conf upon uninstall of the 
>> kmod package to ensure we are not leaving orphaned files on the 
>> system. Something like:
> I did it a little bit different.
> I created a %ghost and named the file /etc/sensors.d/fts-teutates.conf 
> without the Version name. This way it is installed and uninstalled 
> cleanly and only a requires(post) is needed.
> 
> Release 2 is available at https://www.kuehnel.org/kmod-ftsteutates/ for 
> you consideration. :-)
> 
> CU
> Jens
> 

Hi Jens,

Brilliant - thank you.

I've built, signed and released the package to the main elrepo 
repository - it should be available shortly once mirrors have synced.

Only small change I made was to remove:

Requires(preun): %{_sbindir}/dmidecode

which of course was not necessary with your %ghost approach (a far 
better solution than what I proposed!)

I've imported the SPEC file to our github tree here:

https://github.com/elrepo/packages/tree/master/ftsteutates-kmod/el8

Please feel free to submit any changes there and I'll rebuild (preferred 
method), or you can email me changes if you prefer.

I performed a very quick test (without having the matching hardware), 
and the module does weak link against RHEL8.1 and I could load the 
module with modprobe so it probably shouldn't need rebuilding against 
the RHEL8.1 kernel.

Thanks again,

Phil