[elrepo] drbd83-utils packaging question

[Trevor Hemsley]

Hi all

I've been rebuilding various cluster components from FC15 for use with 
CentOS 5 since the pre-built packages available on clusterlabs.org seem 
to be frozen in time and the maintainer there has expressed a wish to 
get out of the packaging business. This means that, for example, 
corosync is 1.2.7 but the latest (and highly recommended by the 
developers) is 1.4.1. What I've rebuilt so far is this lot:

cluster-glue-1.0.6-2.el5.1.x86_64.rpm
corosync-1.4.1-1.el5.x86_64.rpm
corosynclib-1.4.1-1.el5.x86_64.rpm
heartbeat-3.0.4-1.el5.1.x86_64.rpm
heartbeat-libs-3.0.4-1.el5.1.x86_64.rpm
pacemaker-1.1.5-1.el5.x86_64.rpm
pacemaker-libs-1.1.5-1.el5.x86_64.rpm
resource-agents-3.9.2-2.el5.x86_64.rpm

Now the point of this mail is that resource-agents by default builds 
with rgmanager support and this has it include a copy of 
/usr/share/cluster/drbd.sh so I was getting conflicts when trying to 
install it alongside drbd83-utils-8.3.11-1.el5.elrepo. In order to try 
to solve this, I did a diff of the two copies and they differ by a 
single line.

diff -u /usr/share/cluster/drbd.sh /tmp/drbd.sh
--- /usr/share/cluster/drbd.sh  2011-08-08 13:55:22.000000000 +0100
+++ /tmp/drbd.sh        2011-09-19 14:51:31.000000000 +0100
@@ -68,7 +68,7 @@
    role=$(drbdadm role $OCF_RESKEY_resource)
    case $role in
       Primary/*)
-           return $OCF_SUCCESS
+           return $OCF_RUNNING
           ;;
       Secondary/*)
           return $OCF_NOT_RUNNING

I asked on the linux-cluster IRC chat about this to find out which was 
correct and was told by one of the SuSE developers that OCF_RUNNING is 
not defined and is incorrect. OCF_RUNNING is in use by 
drbd83-utils-8.3.11-1.el5.elrepo which probably counts as a bug in the 
elrepo package :-(

I've now rebuilt my resource-agents package without rgmanager support 
and it now does not include the (actually correct) drbd.sh but I do 
wonder if the elrepo drbd83-utils-8.3.11-1.el5.elrepo should be 
including this script in the first place.

Now to go install this lot and see if it works!