[elrepo] drbd83-utils packaging question

[Dag Wieers]

On Tue, 20 Sep 2011, Trevor Hemsley wrote:

> Now the point of this mail is that resource-agents by default builds
> with rgmanager support and this has it include a copy of
> /usr/share/cluster/drbd.sh so I was getting conflicts when trying to
> install it alongside drbd83-utils-8.3.11-1.el5.elrepo. In order to try
> to solve this, I did a diff of the two copies and they differ by a
> single line.
>
> diff -u /usr/share/cluster/drbd.sh /tmp/drbd.sh
> --- /usr/share/cluster/drbd.sh  2011-08-08 13:55:22.000000000 +0100
> +++ /tmp/drbd.sh        2011-09-19 14:51:31.000000000 +0100
> @@ -68,7 +68,7 @@
>    role=$(drbdadm role $OCF_RESKEY_resource)
>    case $role in
>       Primary/*)
> -           return $OCF_SUCCESS
> +           return $OCF_RUNNING
>           ;;
>       Secondary/*)
>           return $OCF_NOT_RUNNING
>
> I asked on the linux-cluster IRC chat about this to find out which was
> correct and was told by one of the SuSE developers that OCF_RUNNING is
> not defined and is incorrect. OCF_RUNNING is in use by
> drbd83-utils-8.3.11-1.el5.elrepo which probably counts as a bug in the
> elrepo package :-(
>
> I've now rebuilt my resource-agents package without rgmanager support
> and it now does not include the (actually correct) drbd.sh but I do
> wonder if the elrepo drbd83-utils-8.3.11-1.el5.elrepo should be
> including this script in the first place.

If this script is indeed incorrect, I can only forward you to discuss this 
with the upstream DRBD project. The drbd.sh file has not been modified 
from upstream:

     https://github.com/elrepo/packages/blob/master/drbd83-utils/el5/drbd83-utils.spec
     https://github.com/elrepo/packages/blob/master/drbd83-utils/el6/drbd83-utils.spec
     https://github.com/elrepo/packages/blob/master/drbd84-utils/el5/drbd84-utils.spec
     https://github.com/elrepo/packages/blob/master/drbd84-utils/el6/drbd84-utils.spec

The upstream Git repository however does not include any fix as you 
propose yet, as can seen from:

     http://git.drbd.org/?p=drbd-8.3.git;a=blob_plain;f=scripts/drbd.sh.rhcs;hb=HEAD
     http://git.drbd.org/?p=drbd-8.4.git;a=blob_plain;f=scripts/drbd.sh.rhcs;hb=HEAD

Please do keep us in the loop for anything related to this so we can 
improve our packages.

Thanks in advance,
-- 
-- dag wieers, dag at wieers.com, http://dag.wieers.com/
-- dagit linux solutions, info at dagit.net, http://dagit.net/

[Any errors in spelling, tact or fact are transmission errors]