[elrepo] kmod-rr174x for el7

[Phil Perry]

On 02/01/15 00:27, Leon Fauster wrote:
> Am 26.12.2014 um 14:42 schrieb Phil Perry <phil at elrepo.org>:
>> I applied your patch and tried building on el7, but without success:
>>
>> [phil at rhel7 rr174x-linux-src-v2.4]$ cd product/rr1740pm/linux/
>> [phil at rhel7 linux]$ make KERNELDIR=/usr/src/kernels/3.10.0-123.el7.x86_64
>> make[1]: Entering directory `/usr/src/kernels/3.10.0-123.el7.x86_64'
>>  CC [M]
>> /home/phil/Desktop/elrepo/el7/rr174x/rr174x-linux-src-v2.4/product/rr1
>>
>>
>> 740pm/linux/.build/os_linux.o
>>  CC [M]
>> /home/phil/Desktop/elrepo/el7/rr174x/rr174x-linux-src-v2.4/product/rr1740pm/linux/.build/osm_linux.o
>> /home/phil/Desktop/elrepo/el7/rr174x/rr174x-linux-src-v2.4/product/rr1740pm/linux/.build/osm_linux.c:
>> In function ‘hpt_do_disk_ioctl’:
>> /home/phil/Desktop/elrepo/el7/rr174x/rr174x-linux-src-v2.4/product/rr1740pm/linux/.build/osm_linux.c:1840:17:
>> warning: unused variable ‘pIdentify’ [-Wunused-variable]
>>  PIDENTIFY_DATA pIdentify;
>>                 ^
>> /home/phil/Desktop/elrepo/el7/rr174x/rr174x-linux-src-v2.4/product/rr1740pm/linux/.build/osm_linux.c:
>> At top level:
>> /home/phil/Desktop/elrepo/el7/rr174x/rr174x-linux-src-v2.4/product/rr1740pm/linux/.build/osm_linux.c:2118:2:
>> error: unknown field ‘proc_info’ specified in initializer
>>  proc_info:               hpt_proc_info26,
>>  ^
>> /home/phil/Desktop/elrepo/el7/rr174x/rr174x-linux-src-v2.4/product/rr1740pm/linux/.build/osm_linux.c:2118:2:
>> warning: initialization from incompatible pointer type [enabled by default]
>> /home/phil/Desktop/elrepo/el7/rr174x/rr174x-linux-src-v2.4/product/rr1740pm/linux/.build/osm_linux.c:2118:2:
>> warning: (near initialization for ‘driver_template.proc_dir’) [enabled
>> by default]
>> make[2]: ***
>> [/home/phil/Desktop/elrepo/el7/rr174x/rr174x-linux-src-v2.4/product/rr1740pm/linux/.build/osm_linux.o]
>> Error 1
>> make[1]: ***
>> [_module_/home/phil/Desktop/elrepo/el7/rr174x/rr174x-linux-src-v2.4/product/rr1740pm/linux/.build]
>> Error 2
>> make[1]: Leaving directory `/usr/src/kernels/3.10.0-123.el7.x86_64'
>> make: *** [rr174x.ko] Error 2
>> [phil at rhel7 linux]$
>>
>>
>> Any suggestions how to fix?
> 
> 
> build only tested with:
> 
> $  cat /etc/redhat-release 
> CentOS release 6.6 (Final)
> 
> $ rpm -qa |grep kernel-lt
> kernel-lt-3.10.63-1.el6.elrepo.x86_64
> kernel-lt-devel-3.10.63-1.el6.elrepo.x86_64
> 
> $ # apply after the first patch
> $ cat <(curl -s http://pastebin.centos.org/14816/raw/) | patch -p0 -b
> 

Thanks, we are making progress. Here is what we have with your two patches:

[phil at rhel7 linux]$ make
make[1]: Entering directory `/usr/src/kernels/3.10.0-123.13.2.el7.x86_64'
  CC [M]
/home/phil/Desktop/elrepo/el7/rr174x/b/product/rr1740pm/linux/.build/os_linux.o
  CC [M]
/home/phil/Desktop/elrepo/el7/rr174x/b/product/rr1740pm/linux/.build/osm_linux.o
/home/phil/Desktop/elrepo/el7/rr174x/b/product/rr1740pm/linux/.build/osm_linux.c:
In function ‘hpt_do_disk_ioctl’:
/home/phil/Desktop/elrepo/el7/rr174x/b/product/rr1740pm/linux/.build/osm_linux.c:1854:17:
warning: unused variable ‘pIdentify’ [-Wunused-variable]
  PIDENTIFY_DATA pIdentify;
                 ^
  CC [M]
/home/phil/Desktop/elrepo/el7/rr174x/b/product/rr1740pm/linux/.build/div64.o
  CC [M]
/home/phil/Desktop/elrepo/el7/rr174x/b/product/rr1740pm/linux/.build/hptinfo.o
  CC [M]
/home/phil/Desktop/elrepo/el7/rr174x/b/product/rr1740pm/linux/.build/config.o
  LD [M]
/home/phil/Desktop/elrepo/el7/rr174x/b/product/rr1740pm/linux/.build/rr174x.o
  Building modules, stage 2.
  MODPOST 1 modules
WARNING: could not find
/home/phil/Desktop/elrepo/el7/rr174x/b/product/rr1740pm/linux/.build/.him_rr1740pm.o.cmd
for
/home/phil/Desktop/elrepo/el7/rr174x/b/product/rr1740pm/linux/.build/him_rr1740pm.o
  CC
/home/phil/Desktop/elrepo/el7/rr174x/b/product/rr1740pm/linux/.build/rr174x.mod.o
  LD [M]
/home/phil/Desktop/elrepo/el7/rr174x/b/product/rr1740pm/linux/.build/rr174x.ko
make[1]: Leaving directory `/usr/src/kernels/3.10.0-123.13.2.el7.x86_64'
[phil at rhel7 linux]$


gcc gives a warning for unused variable ‘pIdentify’ introduced by your
first patch so I removed that line from your patch as it appears not to
be needed on rhel7.

Now we are just left with the following warning:

WARNING: could not find
/home/phil/Desktop/elrepo/el7/rr174x/b/product/rr1740pm/linux/.build/.him_rr1740pm.o.cmd
for
/home/phil/Desktop/elrepo/el7/rr174x/b/product/rr1740pm/linux/.build/him_rr1740pm.o

which is also present on our original el6 builds so I'm assuming we can
ignore that.

So I've build the el7 package based on the above combined two patches,
but with the removal of pIdentify.

Packages are currently syncing to the el7 testing repository and should
show up on the mirrors shortly:

http://elrepo.org/linux/testing/el7/x86_64/RPMS/kmod-rr174x-2.4-1.el7.elrepo.x86_64.rpm

It would be great if you could test when you are able, hardware permitting.

Thanks,

Phil